[Web] Include emscripten headers by default #105800
Conversation
|
So, the goal is to get this include path into the I wonder if there's a way to get Emscripten to give us the its include paths without the user having to specify them? ChatGPT gave me this which seems to work: |
|
Yeah I agree we should set this automatically and not require passing it on the command line. A correct (current) Emscripten setup should have |
Not necessarily. You can setup it to work directly from the emscripten-core/emscripten repo. |
adamscott
force-pushed
the
add-emscripten-include-path
branch
from
0e40f5b to
657945b
Compare
adamscott
changed the title
emscripten_include_path option
adamscott
force-pushed
the
add-emscripten-include-path
branch
from
657945b to
d3f722e
Compare
| emcc_path = Path(str(WhereIs("emcc"))) | ||
| while emcc_path.is_symlink(): | ||
| # For some reason, mypy trips on `Path.readlink` not being defined, somehow. | ||
| emcc_path = emcc_path.readlink() # type: ignore[attr-defined] |
There was a problem hiding this comment.
Any idea why mypy would be unhappy with this @Repiteo ?
| # For some reason, mypy trips on `Path.readlink` not being defined, somehow. | ||
| emcc_path = emcc_path.readlink() # type: ignore[attr-defined] | ||
| emscripten_include_path = emcc_path.parent.joinpath("cache", "sysroot", "include") | ||
| env.Append(CPPPATH=[emscripten_include_path]) |
There was a problem hiding this comment.
Could maybe use CPPEXTPATH (see #104893).
There was a problem hiding this comment.
It fails to build if I use CPPEXTPATH though.
[ 1%] In file included from platform/web/audio_driver_web.cpp:31:
In file included from platform/web/audio_driver_web.h:33:
In file included from platform/web/godot_audio.h:33:
/home/adamscott/dev/apps/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1/cstdint:148:5: error: <cstdint> tried including <stdint.h> but didn't find libc++'s <stdint.h> header. This usually means that your header search paths are not configured properly. The header search paths should contain the C++ Standard Library headers before any C Standard Library, and you are probably using compiler flags that make that not be the case.
148 | # error <cstdint> tried including <stdint.h> but didn't find libc++'s <stdint.h> header. \
| ^
adamscott
force-pushed
the
add-emscripten-include-path
branch
from
d3f722e to
b0e472c
Compare
Currently, developing using Emscripten for the Web platform is kinda a pain. As Emscripten uses by default it's own patched and new headers, the IDEs usually don't know what to do with Emscripten code because including manually those headers is not required.
This code compiles with Emscripten even if clangd complains.
So this PR adds a new option:emscripten_include_path. When added, this path will be included as an include path in the compilation.Edit: This PR now detects and adds the include path automatically, based on the detected binary.
See how great it looks?
Note
If you're using emsdk:
scons platform=web emscripten_include_path=<emsdk path>/upstream/emscripten/cache/sysroot/includeIf you're using directly emscripten:
scons platform=web emscripten_include_path=<emscripten path>/cache/sysroot/include